Add a factory mechanism for the factories called by the chain builder#5561
Merged
NinoFloris merged 2 commits intomainfrom Feb 9, 2024
Merged
Add a factory mechanism for the factories called by the chain builder#5561NinoFloris merged 2 commits intomainfrom
NinoFloris merged 2 commits intomainfrom
Conversation
836ef10 to
8719fd4
Compare
8719fd4 to
40b3069
Compare
NinoFloris
commented
Feb 5, 2024
roji
approved these changes
Feb 7, 2024
Member
roji
left a comment
There was a problem hiding this comment.
Nice trick with the memoization for deferred initialization... Would be nice to have a comment explaining why this hoop is needed though.
Member
|
Also test? |
Member
Author
|
Backported to 8.0.2 via 9e4ff8c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presented without comment.
Fixes #5562