Skip to content

Upgrade to .NET 8 preview 4#5060

Merged
vonzshik merged 5 commits intomainfrom
dotnet-8-preview-4-upgade
May 17, 2023
Merged

Upgrade to .NET 8 preview 4#5060
vonzshik merged 5 commits intomainfrom
dotnet-8-preview-4-upgade

Conversation

@vonzshik
Copy link
Contributor

No description provided.

@vonzshik vonzshik requested a review from roji as a code owner May 17, 2023 05:54
@vonzshik vonzshik force-pushed the dotnet-8-preview-4-upgade branch from 89413d9 to 70ba1f2 Compare May 17, 2023 05:57
Copy link
Member

@Brar Brar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vonzshik
Copy link
Contributor Author

LGTM

Yeah, now to actually make it compile 🐝

@Brar
Copy link
Member

Brar commented May 17, 2023

Yeah, now to actually make it compile.

The upgrade changes are fine. Is the build failure coming from API changes?

@vonzshik
Copy link
Contributor Author

The upgrade changes are fine. Is the build failure coming from API changes?

Yep, DbException(SerializationInfo info, StreamingContext context) and GetObjectData(SerializationInfo info, StreamingContext context) are now marked as obsolete, and as such the compiler doesn't like the fact that we call them.

@Brar
Copy link
Member

Brar commented May 17, 2023

It looks like it's related to serialization of exceptions having changed.

@vonzshik
Copy link
Contributor Author

Native AOT also broken...

@vonzshik vonzshik enabled auto-merge (squash) May 17, 2023 11:04
@vonzshik vonzshik merged commit 03f3c85 into main May 17, 2023
@vonzshik vonzshik deleted the dotnet-8-preview-4-upgade branch May 17, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants