and a few tests that use encodings not all versions of node have, no actual changes to streams here so no rush

ok the issue with the preprocessing test was basically it was relying on some specific tty stuff that was kinda tangential to streams specifically

if others are on the same page about being able to ditch that preprocess test I can merge this

@calvinmetcalf LGTM

As a side note, that test is not targeting readable-stream, as it is using fs, readline and others`, so there is nothing we can fix here.

Can we avoid pulling it the next time? That test also relies on two txt files, those should be removed as well. It's really a test about fs and readline rather than streams.

As a side note, that test it was introduced by @vsemozhetbyt in nodejs/node#7741 and nodejs/node@ea725ed

cc @addaleax

oh right need to remove those

we'd avoid pulling it in if it wasn't named 'stream' it's just a function of the fact that it was touching 3 diff modules and it had to pick one

@calvinmetcalf we should move it then.

I’m not sure what the process for pulling in tests is but if moving that one test in the node repo makes anything easier for anyone that shouldn’t be a problem?

not a big deal any more, I just put something in the code that doesn't pull
it in

On Wed, Aug 31, 2016 at 3:11 PM Anna Henningsen notifications@github.com
wrote:

I’m not sure what the process for pulling in tests is but if moving that
one test in the node repo makes anything easier for anyone that shouldn’t
be a problem?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#225 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABE4n1fsktxGhufYo5JvHPu_77t_-Clfks5qldHugaJpZM4Jm1kx
.

this is a transient error, I'll plan on merging this latter if nobody objects