test: use strictEqual instead of equal in test-domain#9890
Closed
jreading wants to merge 1 commit intonodejs:masterfrom
Closed
test: use strictEqual instead of equal in test-domain#9890jreading wants to merge 1 commit intonodejs:masterfrom
jreading wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
The commit message needs to have the appropriate subsystem prefix, in this case it's |
cjihrig
approved these changes
Dec 1, 2016
Author
|
@mscdex Fixed. Thanks! |
Member
lpinca
approved these changes
Dec 3, 2016
Member
|
CI was a bit too flaky. Running again: https://ci.nodejs.org/job/node-test-pull-request/5182/ |
jasnell
approved these changes
Dec 4, 2016
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM if CI is green. thank you for the PR and for participating in the code-and-learn!
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in c8da009. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: nodejs#9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change