test: swap var->const/let and equal->strictEqual#9888
Closed
pmasucci wants to merge 1 commit intonodejs:masterfrom
Closed
test: swap var->const/let and equal->strictEqual#9888pmasucci wants to merge 1 commit intonodejs:masterfrom
pmasucci wants to merge 1 commit intonodejs:masterfrom
Conversation
Change instances of var with const/let. Change assert.equal to assert.strictEqual.
cjihrig
approved these changes
Dec 1, 2016
Member
lpinca
reviewed
Dec 3, 2016
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); |
Member
There was a problem hiding this comment.
Nit: can you please remove this require after the hasCrypto check?
Edit: we can actually move all the requires with the exception of common after the opensslCli check.
lpinca
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 4, 2016
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM! thank you for the PR and for participating in the code-and-learn!
jasnell
pushed a commit
that referenced
this pull request
Dec 4, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in f9274f0. thank you! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: nodejs#9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: nodejs#9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.