doc: child_process .stdio accepts a String type#9701
Closed
skovhus wants to merge 2 commits intonodejs:v4.x-stagingfrom
Closed
doc: child_process .stdio accepts a String type#9701skovhus wants to merge 2 commits intonodejs:v4.x-stagingfrom
skovhus wants to merge 2 commits intonodejs:v4.x-stagingfrom
Conversation
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. Fixes: nodejs#9636
doc/api/child_process.md
Outdated
| * `input` {String|Buffer} The value which will be passed as stdin to the spawned process | ||
| - supplying this value will override `stdio[0]` | ||
| * `stdio` {Array} Child's stdio configuration. | ||
| * `stdio` {String|Array} Child's stdio configuration. |
Contributor
There was a problem hiding this comment.
The default is pipe here as well.
Fishrock123
approved these changes
Nov 20, 2016
Contributor
Fishrock123
left a comment
There was a problem hiding this comment.
Addressing @thefourtheye's comment would be nice.
Contributor
Author
|
@thefourtheye thanks, I've addressed your comment. |
thefourtheye
approved these changes
Nov 21, 2016
princejwesley
approved these changes
Nov 21, 2016
addaleax
approved these changes
Nov 21, 2016
Member
addaleax
left a comment
There was a problem hiding this comment.
LGTM … I guess we’ll just cherry-pick the 2nd commit onto master after this?
Contributor
|
@addaleax Ya, that will work. But not directly right? Commits have to go through the PR process. |
Member
|
@thefourtheye Yeah, I was asking because the extra commit is going through a review process (this one). But since it doesn’t apply 100 % cleanly I guess another PR is fine, too. |
Contributor
Author
|
@addaleax the default is already documented on master. : ) |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. PR-URL: #9701 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor
|
landed in 0624e51...86440c2 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. PR-URL: #9701 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Document that
execFileSync,execSyncandspawnSyncalso supportsstdioas an Array for v4.x.Fixes: #9636
See master branch pull request here #9637