src: fix build break for !NODE_USE_V8_PLATFORM#8114
Closed
kunalspathak wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix build break for !NODE_USE_V8_PLATFORM#8114kunalspathak wants to merge 1 commit intonodejs:masterfrom
kunalspathak wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Contributor
|
LGTM |
8509238 to
188f54f
Compare
Member
Author
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Aug 15, 2016
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM`. I have submitted PR nodejs/node#8114 to fix this in node repo.
Member
|
LGTM |
Member
Member
Author
|
@Trott , Thanks for triggering CI. Any idea if the failures are known or flaky? My changes shouldn't affect these test cases. |
Member
|
Let's try CI again: https://ci.nodejs.org/job/node-test-pull-request/3695/ |
188f54f to
c3e45ec
Compare
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: nodejs#8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
c3e45ec to
51bbfb6
Compare
Member
Author
|
@nodejs/collaborators , seems I can't push this change to master. Can someone merge it in master so I can pick it up in nodejs/node-chakracore? Thanks in Advance! |
kunalspathak
added a commit
to kunalspathak/node-chakracore
that referenced
this pull request
Aug 17, 2016
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM`. I have submitted PR nodejs/node#8114 to fix this in node repo. PR-URL: nodejs#108 Reviewed-By: Sandeep Agarwal <agarwal.sandeep@microsoft.com>
Contributor
|
landed in 6c7e3d1 Thanks Kunal! |
Member
|
Relanded in 3177b99 to fix metadata |
Trott
pushed a commit
that referenced
this pull request
Aug 17, 2016
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: #8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
|
Should this land in LTS? |
Member
|
I was under the impression that the v8 inspector generally wouldn’t be backported to v4.x… right? (adding the dont-land label but anybody should feel free to correct me!) |
evanlucas
pushed a commit
that referenced
this pull request
Aug 20, 2016
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: #8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
core
Description of change
StartInspectorshould returnboolbut there was signaturemismatch if not building for v8 platform i.e.
!NODE_USE_V8_PLATFORM