doc: general improvements to path.md copy#7122
doc: general improvements to path.md copy#7122jasnell wants to merge 5 commits intonodejs:masterfrom
Conversation
doc/api/path.md
Outdated
There was a problem hiding this comment.
POSIX should probably be capitalized everywhere, except for path.posix code references of course.
|
Updated :-) |
doc/api/path.md
Outdated
There was a problem hiding this comment.
Referencing path.sep specifically here may be a bit misleading in case someone tries to modify path.sep, since path.sep is not actually used internally by the path functions.
|
Updated :-) |
doc/api/path.md
Outdated
There was a problem hiding this comment.
This might be reworded to not mention specific slash characters and instead use wording like 'platform specific path segment separator' or something shorter (but still differentiates from the platform specific path separator -- ; or :).
|
Done |
doc/api/path.md
Outdated
|
Updated! |
doc/api/path.md
Outdated
There was a problem hiding this comment.
This sounds a bit odd, what about 'Any empty path strings are ignored.'?
|
Updated |
|
ping @mscdex |
doc/api/path.md
Outdated
There was a problem hiding this comment.
minor nit: s/file/file/directory/ or s/file/file system/ ? Although the latter makes it sounds like it necessarily touches the file system, which is not always the case.
doc/api/path.md
Outdated
There was a problem hiding this comment.
s/A file path// here and all of the other instances
|
@mscdex ... updated! |
|
LGTM |
PR-URL: #7122 Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in a173483 |
PR-URL: #7122 Reviewed-By: Brian White <mscdex@mscdex.net>
Checklist
Affected core subsystem(s)
doc (path)
Description of change
General improvements to path.md documentation
@nodejs/documentation