Conversation
Apply a small patch that makes node-gyp fetch the tarballs from https://iojs.org/ instead of http://nodejs.org/ A patch better suited for inclusion upstream will be put together shortly. PR-URL: nodejs#343 Reviewed-By: Rod Vagg <rod@vagg.org>
* Fetch from the correct url. * Link compiled addons with iojs.lib instead of node.lib. * Disable checksum checks for iojs.lib until our website supports them. PR: nodejs#422 Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Rod Vagg <rod@vagg.org>
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 31, 2015
PR-URL: #663 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
Thanks @othiym23, landed in 40e29dc...bce7a26. |
Contributor
I think we need #493 to land before the node-gyp PR can be merged cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shorter changelog:
dc51810#6243 /
#6854
npm dist-tags: Directlymanage
dist-tagson packages. Most notably,dist-tagscan now be deleted.(@othiym23)
c963eb2#7181
npm access publicandnpm access restricted: Toggle visibility of scoped packages (depends on forthcoming changes to npm package registry).(@othiym23)
I reapplied the floating patches for
node-gyp(any idea when a new version of that will be published, @rvagg or @TooTallNate?).NOTE: with the help of @misterdjules, I figured out that there is a problem in npm's tests that cause test hangs in both Node 0.11.16-pre and io.js 1.0.x. As far as either of us have been able to determine, these hangs (which are related to a change in Keep-Alive behavior made due to recent changes in
http.Agenthandling) do not affect the behavior of npm itself. Changes are required to thetest-npmtarget in theMakefilefor these hangs to manifest, and I will put together a PR with those changes after I've had a chance to fix the failing tests.There are some other tweaks to Agent behavior in npm to address proxy and
rejectUnauthorizedregressions, but those are currently in testing innpm@2.5.0.