deps: cherry-pick libuv/libuv@e640dc9 - #65118
Merged
Merged
Conversation
Signed-off-by: ulofiai <monsterking@tutamail.com>
Collaborator
|
Review requested:
|
aduh95
approved these changes
Aug 11, 2026
Collaborator
Collaborator
Collaborator
|
Landed in 38e3955 |
erossignon
added a commit
to node-opcua/node-opcua
that referenced
this pull request
Aug 25, 2026
Neither libuv fix Windows needs is in a released 24.x: the async-close assertion (nodejs/node#61999) and the 24.16.0 fs-event regression (nodejs/node#65118) are both on main only. No pin can be green, so float 24.x non-blocking - it goes green on its own once a release carries both. The 24.19.0 pin this replaces was strictly worse than the 24.15.0 before it, which predates the fs-event regression and so carries one bug, not two. Leak detection drops from five jobs to one. Its checks are JS-level and platform-independent, so the other four repeated a single signal. It gets --expose-gc via NODE_OPTIONS rather than the test:parallel script, keeping that a plain test run for developers; without the flag the detector costs time and measures nothing. parallel_test.js: the CPU=<n> override is honoured again, and the worker floor of 4 applies only to the computed default.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ulofiai <monsterking@tutamail.com> PR-URL: #65118 Fixes: #63638 Refs: libuv/libuv#5152 Refs: libuv/libuv@e640dc9 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: ulofiai <monsterking@tutamail.com> PR-URL: #65118 Fixes: #63638 Refs: libuv/libuv#5152 Refs: libuv/libuv@e640dc9 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the upstream libuv fix for Windows fs-event watchers using 8.3 short paths.
When the watched directory is supplied in short-path form, resolving an event path to its long form can make it no longer share the stored directory prefix. Instead of asserting (or calculating an invalid relative path in release builds), fall back to the filename returned by ReadDirectoryChangesW, which is already relative to the watched directory. The regression test now creates a real directory with distinct long and short forms and tries both the Windows temporary directory and the current directory.
Fixes: #63638
Refs: libuv/libuv#5152
Refs: libuv/libuv@e640dc9