Skip to content

Revert "build, doc: generate node.1 with doc-kit"#64091

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:revert-node.1-doc-kit
Open

Revert "build, doc: generate node.1 with doc-kit"#64091
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:revert-node.1-doc-kit

Conversation

@aduh95

@aduh95 aduh95 commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts #62044 as that introduced a dependency on running npm to be able to build node.

I ran the following to produce this PR:

make out/doc/node.1 
git revert --no-edit --no-gpg-sign 81e93dff3b4b1d2bea76cb70855f449e38de49fe
mv out/doc/node.1 doc/.
git add doc
git commit --amend -s --no-edit

Ideally we'd want a linter to ensure node.1 stays up-to-date, but this can come in a follow-up.

@aduh95
Revert "build, doc: generate node.1 with doc-kit"
f5762e1 
This reverts commit 81e93df.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/config
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 23, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 23, 2026
sxa
sxa approved these changes Jun 23, 2026
View reviewed changes

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that this is a straight revert.

mcollina
mcollina approved these changes Jun 23, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74380/

@richardlau richardlau mentioned this pull request Jun 23, 2026
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74382/

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 72 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aduh95 @nodejs-github-bot @mcollina @panva @tniessen @richardlau @sxa @marco-ippolito @avivkeller