Skip to content

lib: use primordials in freelist.js#61208

Open
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Ayoub-Mabrouk:lib-use-primordials-freelist
Open

lib: use primordials in freelist.js#61208
Ayoub-Mabrouk wants to merge 1 commit intonodejs:mainfrom
Ayoub-Mabrouk:lib-use-primordials-freelist

Conversation

@Ayoub-Mabrouk
Copy link

Replace native methods with primordials for consistency and security. This improves protection against prototype pollution.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 29, 2025
@avivkeller avivkeller added the needs-benchmark-ci PR that need a benchmark CI run. label Dec 29, 2025
@Ayoub-Mabrouk Ayoub-Mabrouk force-pushed the lib-use-primordials-freelist branch from bdbd96d to e1f3326 Compare December 29, 2025 16:45
Replace native methods with primordials.
@Ayoub-Mabrouk Ayoub-Mabrouk force-pushed the lib-use-primordials-freelist branch from e1f3326 to 06d364e Compare December 29, 2025 17:47
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (05d6b9b) to head (06d364e).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61208      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         703      703              
  Lines      208599   208615      +16     
  Branches    40229    40252      +23     
==========================================
+ Hits       184685   184692       +7     
- Misses      15939    15941       +2     
- Partials     7975     7982       +7     
Files with missing lines Coverage Δ
lib/internal/freelist.js 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Feb 17, 2026

Duplicate of #36565, until proven otherwise we should expect this to perform poorly

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1801/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments