tools: Compile maglev files into v8_compiler if maglev is disabled#58861
Closed
ziyao233 wants to merge 1 commit intonodejs:mainfrom
Closed
tools: Compile maglev files into v8_compiler if maglev is disabled#58861ziyao233 wants to merge 1 commit intonodejs:mainfrom
ziyao233 wants to merge 1 commit intonodejs:mainfrom
Conversation
v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler depends on, causing duplicate symbols during linking if maglev is disabled or not available for the target. Let's move the files into v8_compiler target where they are used.
Collaborator
|
Review requested:
|
Contributor
Author
Here's an example log when building fails with duplicate symbols on riscv64, where maglev compiler is available but not yet enabled in NodeJS by default. The error could be reproduced on loongarch64 as well. |
joyeecheung
approved these changes
Jun 30, 2025
Collaborator
Collaborator
Collaborator
Collaborator
richardlau
approved these changes
Jul 4, 2025
RafaelGSS
approved these changes
Jul 5, 2025
richardlau
pushed a commit
that referenced
this pull request
Jul 7, 2025
v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler depends on, causing duplicate symbols during linking if maglev is disabled or not available for the target. Let's move the files into v8_compiler target where they are used. Fixes: #58954 PR-URL: #58861 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
|
Landed in 7be2528. |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler depends on, causing duplicate symbols during linking if maglev is disabled or not available for the target. Let's move the files into v8_compiler target where they are used. Fixes: #58954 PR-URL: #58861 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler depends on, causing duplicate symbols during linking if maglev is disabled or not available for the target. Let's move the files into v8_compiler target where they are used.