[20.x backport] worker: add postMessageToThread#57101
Closed
ShogunPanda wants to merge 1 commit intonodejs:v20.x-stagingfrom
Closed
[20.x backport] worker: add postMessageToThread#57101ShogunPanda wants to merge 1 commit intonodejs:v20.x-stagingfrom
ShogunPanda wants to merge 1 commit intonodejs:v20.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
Collaborator
Collaborator
PR-URL: nodejs#53682 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2e70ecf to
4e1795f
Compare
Collaborator
Collaborator
Collaborator
Contributor
Author
|
@marco-ippolito I have an unrelated error on this PR but all the tests are passing. What shall I do? |
Member
I only see coverage failing which is fine. Can you paste the error? |
Member
|
@nodejs/platform-windows we are getting a range error on windows |
Member
|
This looks like an out of memory error. Did it happen multiple times ? |
Contributor
Author
|
Yes, I retried that several times. But it seems not related to my changes. |
Member
|
Unrelated indeed. the daily v20.x build fails with the same test: https://ci.nodejs.org/view/All/job/node-daily-v20.x-staging/472/ |
Contributor
Author
|
So are we good to merge this? |
marco-ippolito
approved these changes
Feb 20, 2025
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 20, 2025
PR-URL: #53682 Backport-PR-URL: #57101 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
|
Landed in 73b5c16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 66a635c