Skip to content

url: group slashed protocols by protocol name #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nettofarah wants to merge 1 commit into from
Closed

url: group slashed protocols by protocol name #5380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
url: group slashed protocols by protocol name 
Reorder slashed protocols so they are grouped by protocol name. This is
done so it doesn't look like we're duplicating protocol names at the
bottom of the list.

PR-URL: #5380
Reviewed-By: Benjamin Gruenbaum
Reviewed-By: Evan Lucas <evanlucas@me.com>
  • Loading branch information
@nettofarah
nettofarah committed Feb 25, 2016
commit 4df108e9459f57123c7f9a0bf370b972786d3da3
8 changes: 4 additions & 4 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ const hostlessProtocol = {
// protocols that always contain a // bit.
const slashedProtocol = {
'http': true,
'https': true,
'ftp': true,
'gopher': true,
'file': true,
'http:': true,
'https': true,
'https:': true,
'ftp': true,
'ftp:': true,
'gopher': true,
'gopher:': true,
'file': true,
'file:': true
};
const querystring = require('querystring');
Expand Down