deps: V8: fixed unable to find library -lrt #51852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unable to find library -lrt when building for android aarch64
Collaborator
|
Review requested:
|
joyeecheung
approved these changes
Feb 23, 2024
Collaborator
Collaborator
Collaborator
Member
|
Duplicate of #51632? |
Member
|
Yes, this does link to libc explicitly though as #50184 (comment) mentioned the Android documentation said that it is not necessary. |
Contributor
Author
Contributor
Linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #50184.
To fix it I made the following changes to the file
tools/v8_gypfiles/v8.gyp:['is_android', { 'sources': [ '<(V8_ROOT)/src/base/platform/platform-posix.cc', '<(V8_ROOT)/src/base/platform/platform-posix.h', '<(V8_ROOT)/src/base/platform/platform-posix-time.cc', '<(V8_ROOT)/src/base/platform/platform-posix-time.h', ], 'link_settings': { 'target_conditions': [ ['_toolset=="host" and host_os=="linux"', { 'libraries': [ - '-ldl', + '-ldl', + '-lc' - '-lrt' ], }], ], }, 'target_conditions': [ ['_toolset=="host"', { 'sources': [ '<(V8_ROOT)/src/base/debug/stack_trace_posix.cc', '<(V8_ROOT)/src/base/platform/platform-linux.cc', ], }, { 'sources': [ '<(V8_ROOT)/src/base/debug/stack_trace_android.cc', '<(V8_ROOT)/src/base/platform/platform-linux.cc', ], }], ], }],