Skip to content

doc: add CanadaHonk to triagers#50848

Closed
CanadaHonk wants to merge 1 commit intonodejs:mainfrom
CanadaHonk:canadahonk-triager
Closed

doc: add CanadaHonk to triagers#50848
CanadaHonk wants to merge 1 commit intonodejs:mainfrom
CanadaHonk:canadahonk-triager

Conversation

@CanadaHonk
Copy link
Member

@CanadaHonk CanadaHonk commented Nov 21, 2023

I started making PRs and discussing in issues a few months ago, mostly perf related. Becoming a triager helps the workflow and is more of a commitment for the future :)

I have read the Code of Conduct plus Triage Guide and agree to both. Thank you!

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 21, 2023
anonrig
anonrig approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely yes!

RaisinTen
RaisinTen approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🎉
cc @nodejs/issue-triage

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2023
VoltrexKeyva
VoltrexKeyva approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2023
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 22, 2023

@CanadaHonk - looks like your email id is not configured in git, it is appearing as GitHub default 19228318+CanadaHonk@users.noreply.github.com. Do you want to try pushing again by setting those?

ref: https://docs.github.com/en/get-started/getting-started-with-git/setting-your-username-in-git

@CanadaHonk
Copy link
Member Author

CanadaHonk commented Nov 22, 2023

Sorry, should be fixed now :)

gireeshpunathil pushed a commit that referenced this pull request Nov 22, 2023
@CanadaHonk @gireeshpunathil
doc: add CanadaHonk to triagers
081474b 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 22, 2023

landed in 081474b

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 22, 2023

invitation sent for joining the triage team 🎉

targos pushed a commit that referenced this pull request Nov 23, 2023
@CanadaHonk @targos
doc: add CanadaHonk to triagers
ebc6fe8 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@CanadaHonk @martenrichter
doc: add CanadaHonk to triagers
b9a2f28 
PR-URL: nodejs#50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@CanadaHonk
doc: add CanadaHonk to triagers
3c46275 
PR-URL: nodejs#50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@CanadaHonk @RafaelGSS
doc: add CanadaHonk to triagers
e116fcd 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@CanadaHonk @RafaelGSS
doc: add CanadaHonk to triagers
0b09cdd 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
1fef045 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
033c482 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
135ec0a 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
30baacb 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@mertcanaltin
Copy link
Member

mertcanaltin commented Jan 14, 2024

Welcome aboard ❤️

@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@meixg meixg meixg approved these changes

@H4ad H4ad H4ad approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.