url: more sophisticated brand check for URLSearchParams#47414
Merged
Trott merged 1 commit intonodejs:mainfrom Apr 7, 2023
Merged
url: more sophisticated brand check for URLSearchParams#47414Trott merged 1 commit intonodejs:mainfrom
Trott merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Apr 5, 2023
Member
anonrig
approved these changes
Apr 6, 2023
benjamingr
approved these changes
Apr 6, 2023
Member
Results are very good IMO: |
Trott
approved these changes
Apr 7, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
The performance impact might be because Also since this PR doesn't change the status quo, I propose that we not block it on the resolution from #47218. |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
Use private properties and static {} blocks.
PR-URL: nodejs#47414
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 4b448c8 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Use private properties and static {} blocks.
PR-URL: #47414
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use private properties, following the lead of the
URLclass.