Skip to content

build, deps, tools: avoid excessive LTO #47313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Apr 6, 2023
Merged

build, deps, tools: avoid excessive LTO #47313

nodejs-github-bot merged 1 commit into from
Apr 6, 2023

Conversation

@rockdrilla
Copy link
Contributor

@rockdrilla rockdrilla commented Mar 30, 2023

Don't link intermediate executables with LTO in order to speed up overall build time.

Signed-off-by: Konstantin Demin rockdrilla@gmail.com

@rockdrilla
build, deps, tools: avoid excessive LTO
f8036cd 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2023

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Mar 30, 2023
bnoordhuis
bnoordhuis approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch, thanks.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50768/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5263/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5263/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5263/

This was referenced Apr 2, 2023
Open
Open
@rockdrilla
Copy link
Contributor Author

rockdrilla commented Apr 4, 2023

Btw, PGO is also produces the same issues. I'll produce next merge request after this one.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 4, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50927/

@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Open
26 tasks
mhdawson
mhdawson approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50990/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit c3cd75d into nodejs:main Apr 6, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2023

Landed in c3cd75d

@rockdrilla rockdrilla deleted the lto branch April 6, 2023 08:32
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@rockdrilla @RafaelGSS
build, deps, tools: avoid excessive LTO
9a4d21d 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: #47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@rockdrilla @danielleadams
build, deps, tools: avoid excessive LTO
580b8f0 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: #47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@rockdrilla @MoLow
build, deps, tools: avoid excessive LTO
db910dd 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: nodejs#47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
0dbdc8a 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
build: avoid excessive LTO
483cffd 
Don't link intermediate executables with LTO in order to speed up overall build time.

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
2781509 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
build: avoid excessive LTO
3a63e58 
Don't link intermediate executables with LTO in order to speed up overall build time.

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
947cbca 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
@rockdrilla rockdrilla mentioned this pull request Aug 8, 2023
Open
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
b6ee30a 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
build: avoid excessive LTO
247975a 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
138fe81 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
build: avoid excessive LTO
88bcd37 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
3940c99 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
build: avoid excessive LTO
71078a5 
Don't link intermediate executables with LTO in order to speed up
overall build time.

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
rockdrilla added a commit to rockdrilla/fork.node that referenced this pull request Aug 8, 2023
@rockdrilla
tools: remove non-working condition
ca30864 
condition doesn't apply to this target type

Fixes: nodejs#47313
Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rockdrilla @nodejs-github-bot @bnoordhuis @jasnell @richardlau @mhdawson