test: add coverage for custom loader hooks with permission model#46977
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 8, 2023
Merged
test: add coverage for custom loader hooks with permission model#46977nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Contributor
Author
|
/cc @nodejs/loaders |
Member
|
Love this check
…On Mon, Mar 6, 2023 at 11:14 AM Antoine du Hamel ***@***.***> wrote:
/cc @nodejs/loaders <https://github.com/orgs/nodejs/teams/loaders>
—
Reply to this email directly, view it on GitHub
<#46977 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZJI3LWPATUABRFW3246TW2YLPLANCNFSM6AAAAAAVRMSFNA>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
targos
approved these changes
Mar 6, 2023
cjihrig
approved these changes
Mar 6, 2023
19 tasks
GeoffreyBooth
approved these changes
Mar 7, 2023
Contributor
Author
19 tasks
Collaborator
Collaborator
|
Landed in b8ef1b4 |
This was referenced Mar 9, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46977 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.