async_hooks: add async local storage propagation benchmarks#46414
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 3, 2023
Merged
async_hooks: add async local storage propagation benchmarks#46414nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
4881769 to
fa59ad3
Compare
jasnell
approved these changes
Jan 30, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Jan 30, 2023
This comment was marked as outdated.
This comment was marked as outdated.
JungMinu
approved these changes
Jan 31, 2023
Add micro-benchmarks to verify the performance degradation related to the number of active `AsyncLocalStorage`s. With these benchmarks, trying to improve the async context propagation to be an O(1) operation, which is an operation more frequent compared to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`.
fa59ad3 to
22c8683
Compare
Member
Author
|
Style fix after #46424 landed. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Feb 3, 2023
Collaborator
Collaborator
|
Landed in 3000d77 |
This was referenced Feb 5, 2023
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Add micro-benchmarks to verify the performance degradation related to the number of active `AsyncLocalStorage`s. With these benchmarks, trying to improve the async context propagation to be an O(1) operation, which is an operation more frequent compared to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`. PR-URL: #46414 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Add micro-benchmarks to verify the performance degradation related to the number of active `AsyncLocalStorage`s. With these benchmarks, trying to improve the async context propagation to be an O(1) operation, which is an operation more frequent compared to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`. PR-URL: #46414 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add micro-benchmarks to verify the performance degradation related to
the number of active
AsyncLocalStorages.With these benchmarks, trying to improve the async context propagation
to be an O(1) operation, which is an operation more frequent compared
to
asyncLocalStorage.runandasyncLocalStorage.getStore.