tools: add GitHub token permissions to label flaky-test issues#45308
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 4, 2022
Merged
tools: add GitHub token permissions to label flaky-test issues#45308nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
Collaborator
|
Review requested:
|
Contributor
|
Is read permission actually enough for labelling issues? That seems quite counter intuitive to me. |
Contributor
Author
No, you are right, it is not. The permission that allows labelling the issues is The |
lpinca
approved these changes
Dec 3, 2022
Collaborator
|
Landed in de696d7 |
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> PR-URL: #45308 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimum GITHUB_TOKEN permissions for
label-flaky-test-issue.ymlworkflow.Motivation: Setting minimum permissions on workflow's top level is good practice. Similar changes were previously discussed in #43743. Since label flaky-test issues workflow was recently added, this PR is a small update to restrict it's permissions.
About me: I'm Gabriela and I work on behalf of Google and the OpenSSF suggesting supply-chain security changes :)
Signed-off-by: Gabriela Gutierrez gabigutierrez@google.com