Skip to content

src,fs: refactor duplicated code in fs.readdir #43204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jul 29, 2022
Merged

src,fs: refactor duplicated code in fs.readdir #43204

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
452f015
src,fs: refactor duplicated code in fs.readdir
daeyeon May 25, 2022
dca7ebd
fixup: rename function name
daeyeon May 25, 2022
9f7cd76
check: verify linting cc
daeyeon May 25, 2022
9506649
fixup: revert lint check
daeyeon May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: revert lint check 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed May 25, 2022
commit 9506649b68be445a06839bacebaa6c302cc8279c
3 changes: 1 addition & 2 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,7 @@ void AfterScanDir(uv_fs_t* req) {
}
name_v.push_back(filename);

if (with_file_types)
type_v.emplace_back(Integer::New(isolate, ent.type));
if (with_file_types) type_v.emplace_back(Integer::New(isolate, ent.type));
Comment thread
daeyeon marked this conversation as resolved.
}

if (with_file_types) {
Expand Down