Conversation
Member
Well, that didn't work. |
Trott
approved these changes
Oct 10, 2021
Member
Trott
left a comment
There was a problem hiding this comment.
I manually confirmed that none of these are duplicates so this is ready to land.
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Oct 10, 2021
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40392 ✔ Done loading data for nodejs/node/pull/40392 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40392) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40392 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40392 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 10 Oct 2021 00:14:07 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775618121 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775620278 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775713003 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1326708013 |
PR-URL: #40392 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
31b9603 to
49b7ec9
Compare
Member
|
Landed in 49b7ec9 |
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40392 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.js.{{ env.DUPLICATES }}