doc: fix property name 'detail' of performanceEntry#40019
Closed
ChristianBoehlke wants to merge 1 commit intonodejs:masterfrom
ChristianBoehlke:perf-hooks-details
Closed
doc: fix property name 'detail' of performanceEntry#40019ChristianBoehlke wants to merge 1 commit intonodejs:masterfrom ChristianBoehlke:perf-hooks-details
ChristianBoehlke wants to merge 1 commit intonodejs:masterfrom
ChristianBoehlke:perf-hooks-details
Conversation
jasnell
approved these changes
Sep 6, 2021
targos
approved these changes
Sep 6, 2021
lpinca
approved these changes
Sep 6, 2021
tniessen
approved these changes
Sep 7, 2021
Member
tniessen
left a comment
There was a problem hiding this comment.
Thank you for the contribution, @ChristianBoehlke!
Contributor
|
Landed in 9f7412a...6e9a54c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
PR-URL: #40019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
cafca
added a commit
to cafca/DefinitelyTyped
that referenced
this pull request
Sep 12, 2021
This spelling mistake in a property name has been fixed in node.js per nodejs/node#40019
7 tasks
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Sep 19, 2021
…cafca * Fix property 'detail' of PerformanceEntry This spelling mistake in a property name has been fixed in node.js per nodejs/node#40019 * Add missing comma * Fix 'detail' property name in perf_hooks test
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the
performanceEntrythat is passed to the callback ofPerformanceObserverdoes not have a propertydetailsbut it does have a propertydetail(without the "s"). This is also in line with the deprecation warning and what I could find in the source code:node/lib/internal/perf/performance_entry.js
Line 44 in 1c4df35
node/lib/internal/perf/performance_entry.js
Line 63 in 1c4df35
node/lib/internal/perf/observe.js
Line 75 in 1c4df35
In case this is correct: I have changed the documentation accordingly. Please let me know if I can do anything else.
Thank you!