[v14.x backport] src: use SPrintF in ProcessEmitWarning#39419
Closed
RaisinTen wants to merge 2 commits intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] src: use SPrintF in ProcessEmitWarning#39419RaisinTen wants to merge 2 commits intonodejs:v14.x-stagingfrom
RaisinTen wants to merge 2 commits intonodejs:v14.x-stagingfrom
Conversation
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Jul 17, 2021
PR-URL: nodejs#38758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#39419
4e0a336 to
9ce9b14
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
You probably need to backport #39091 alongside it. |
Member
Author
Contributor
|
You can use the following commands:
I think it makes no sense to backport one without the other, so I'd say that yes, you are supposed to include both in this PR. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@aduh95 Thanks, done! PTAL. |
targos
approved these changes
Jul 18, 2021
Collaborator
aduh95
approved these changes
Jul 18, 2021
8ea39c6 to
4ac719f
Compare
PR-URL: nodejs#38758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#39419
PR-URL: nodejs#39091 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
e91b66f to
86ab15d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
richardlau
approved these changes
Jul 19, 2021
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #39091 Backport-PR-URL: #39419 Fixes: #39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 90fae0f...5f7c331 |
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #39091 Backport-PR-URL: #39419 Fixes: #39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Backport-PR-URL: nodejs#39419
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#39091 Backport-PR-URL: nodejs#39419 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #38758
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Original pull request: #38758