http: refactor to remove redundant argument of _deferToConnect#38598
Closed
pd4d10 wants to merge 1 commit intonodejs:masterfrom
Closed
http: refactor to remove redundant argument of _deferToConnect#38598pd4d10 wants to merge 1 commit intonodejs:masterfrom
pd4d10 wants to merge 1 commit intonodejs:masterfrom
Conversation
0e4595b to
8fd04b1
Compare
Collaborator
Contributor
Member
|
@nodejs/http |
Trott
approved these changes
May 8, 2021
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM if CITGM doesn't find anything new outside of the usual expected set of errors/failures
Contributor
|
Sorry, I misconfigured the previous citgm run. https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2689/ |
lpinca
approved these changes
May 8, 2021
aduh95
approved these changes
May 9, 2021
Contributor
We have some errors on |
Member
|
I think it's just a flake on Fastify, I can't reproduce locally. |
Collaborator
dnlup
pushed a commit
that referenced
this pull request
May 14, 2021
PR-URL: #38598 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Contributor
targos
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38598 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's considered a private method, I guess it's safe to remove this unused argument.
All references are here:
node/lib/_http_client.js
Lines 879 to 886 in 52e4fb5