doc: document ctor of ReadStream and WriteStream in tty#38021
Closed
Ayase-252 wants to merge 2 commits intonodejs:mainfrom
Closed
doc: document ctor of ReadStream and WriteStream in tty#38021Ayase-252 wants to merge 2 commits intonodejs:mainfrom
Ayase-252 wants to merge 2 commits intonodejs:mainfrom
Conversation
jasnell
approved these changes
Apr 28, 2021
aymen94
approved these changes
Oct 19, 2023
Contributor
|
This needs a rebase. |
Member
|
Hi guys, just checkin to see where the PR is at, are you happy for me to continue the work until its land and add you as a co-author? @Ayase-252 |
Member
Author
Yes, please feel free to continue, as I don't have time to follow right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documents for constructors of both
tty.ReadStreamandtty.WriteStream.Fixes: #37780