Skip to content

test: mark flaky tests on IBM i #36986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
richardlau wants to merge 1 commit into from
Closed

test: mark flaky tests on IBM i #36986

richardlau wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Jan 18, 2021

Refs: #34410
Refs: #36925
Refs: #36929

Underlying issues still need to be investigated, but this will prevent these
failures from failing the daily builds.

cc @nodejs/platform-ibmi

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jan 18, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35606/ (✔️)
IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/228/ (yellow (as expected))

@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Jan 18, 2021
@richardlau richardlau mentioned this pull request Jan 18, 2021
Open
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 72 hours to land. label Jan 18, 2021
@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Shouldn't be any reason for this to wait the full time to land. 👍🏻 to fast-track

mhdawson
mhdawson approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott pushed a commit that referenced this pull request Jan 19, 2021
@richardlau @Trott
test: mark flaky tests on IBM i
863ec7d 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 19, 2021

Landed in 863ec7d

@Trott Trott closed this Jan 19, 2021
@richardlau richardlau deleted the ibmi branch January 19, 2021 14:42
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@richardlau @ruyadorno
test: mark flaky tests on IBM i
3a122aa 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@richardlau @ruyadorno
test: mark flaky tests on IBM i
7acea78 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@richardlau @targos
test: mark flaky tests on IBM i
5408f51 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@richardlau @nodejs-github-bot @jasnell @Trott @cjihrig @mhdawson