test: fix variable name for non-RSA keys#36912
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix variable name for non-RSA keys#36912tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
panva
approved these changes
Jan 13, 2021
cjihrig
approved these changes
Jan 13, 2021
lpinca
approved these changes
Jan 13, 2021
Collaborator
tniessen
added a commit
that referenced
this pull request
Jan 15, 2021
PR-URL: #36912 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in ccc6776, thanks for reviewing. |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36912 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point here is that the keys are not RSA keys, so the variable name
rsaKeysis misleading/wrong. These ECDSA keys are used to test that the RSA algorithm rejects non-RSA keys.