doc: use _code name_ rather than _codename_#36611
Merged
Trott merged 1 commit intonodejs:masterfrom Dec 27, 2020
Merged
Conversation
targos
approved these changes
Dec 23, 2020
richardlau
approved these changes
Dec 23, 2020
Member
richardlau
left a comment
There was a problem hiding this comment.
Will you be adding codename/codenames to the list of prohibited strings?
Member
Author
I wasn't planning on it but now that you mention it, I suppose it makes sense. |
benjamingr
approved these changes
Dec 24, 2020
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: nodejs#36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Landed in 4d3e87d |
Member
Author
Doing that will flag line 76 of the README so that will need to be worked out first: alias for the latest Current release. The latest-_codename_ directory is an |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: #36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: #36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is excrutiatingly minor, but every authoritative resource I've
checked (which is to say, a few dictionaries) uses "code name" primarily
or exclusively. Let's follow suit.
Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes