doc: use links to MS guide in style guide#34871
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Avoid repeating too much from the Microsoft guide by providing links to it.
watilde
approved these changes
Aug 22, 2020
Contributor
|
Should we be worried of MS changing URLs which would break these links? Or maybe changing the rules? IMHO having the rules repeated in our docs is less risky and more reliable. |
Member
Author
I'm OK dealing with it when if/when it happens. |
jasnell
approved these changes
Aug 24, 2020
fhinkel
approved these changes
Aug 24, 2020
trivikr
approved these changes
Aug 25, 2020
Trott
added a commit
that referenced
this pull request
Aug 25, 2020
Avoid repeating too much from the Microsoft guide by providing links to it. PR-URL: #34871 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
Landed in b93325c |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
Avoid repeating too much from the Microsoft guide by providing links to it. PR-URL: #34871 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeating too much from the Microsoft guide by providing links to
it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes