tls: enable renegotiation when using boringssl#34832
Closed
nornagon wants to merge 1 commit intonodejs:masterfrom
Closed
tls: enable renegotiation when using boringssl#34832nornagon wants to merge 1 commit intonodejs:masterfrom
nornagon wants to merge 1 commit intonodejs:masterfrom
Conversation
5 tasks
cjihrig
approved these changes
Aug 18, 2020
codebytere
approved these changes
Aug 18, 2020
Contributor
|
nit: it would be better to spell out BoringSSL in the first line of the commit message for those who aren't familiar with "bssl" |
jasnell
approved these changes
Aug 18, 2020
addaleax
approved these changes
Aug 18, 2020
bnoordhuis
approved these changes
Aug 19, 2020
Trott
approved these changes
Aug 21, 2020
Collaborator
Trott
pushed a commit
that referenced
this pull request
Aug 22, 2020
PR-URL: #34832 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Member
Member
BethGriggs
pushed a commit
that referenced
this pull request
Aug 24, 2020
PR-URL: #34832 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34832 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34832 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables TLS renegotiation when building Node with BoringSSL, which matches
OpenSSL's default behavior.
No effect when building against OpenSSL.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes