src: fix ignore GCC -Wcast-function-type for older compilers#31524
Closed
lundibundi wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix ignore GCC -Wcast-function-type for older compilers#31524lundibundi wants to merge 1 commit intonodejs:masterfrom
lundibundi wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
Contributor
|
As mentioned in the issue, the new warning was visible in CI even. Checking the output for this PR on the Ubuntu 18.04 CI node, I no longer see the new warning. |
richardlau
approved these changes
Jan 26, 2020
Member
In addition to our CI (which uses pre-8 GCC compilers), our Travis CI builds use GCC 6 and GitHub Actions Linux runners use GCC 7. The new warnings no longer appear in the logs for those builds for this PR while they do for the equivalent logs for #31475. |
cjihrig
approved these changes
Jan 26, 2020
Trott
approved these changes
Jan 28, 2020
Member
|
Landed in 2462a2c |
This was referenced Feb 5, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31517
I don't have an easy access to pre-8 GCC compiler so I haven't explicitly tested this. Perhaps @mscdex can check if this fixes your issue?
GCC8 changelog https://gcc.gnu.org/gcc-8/changes.html which denotes the addition of
Wcast-function-type.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes