doc: document missing properties in child_process#31342
Closed
HarshithaKP wants to merge 4 commits intonodejs:masterfrom
Closed
doc: document missing properties in child_process#31342HarshithaKP wants to merge 4 commits intonodejs:masterfrom
HarshithaKP wants to merge 4 commits intonodejs:masterfrom
Conversation
Member
Author
|
According to my understanding, |
addaleax
approved these changes
Jan 13, 2020
addaleax
approved these changes
Jan 14, 2020
Trott
approved these changes
Jan 15, 2020
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM with entry moved to retain alphabetical order.
doc/api/child_process.md
Outdated
| For [`child_process.exec()`][], its value will be the name of the shell | ||
| in which the child process is launched. | ||
|
|
||
| ### `subprocess.spawnargs` |
Member
There was a problem hiding this comment.
spawnargs should go before spawnfile rather than after it.
Trott
approved these changes
Jan 16, 2020
Trott
approved these changes
Jan 16, 2020
Member
|
Landed in 3299de8 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 16, 2020
Add documentation for subprocess.exitCode, subprocess.signalCode, subprocess.spawnargs, and subprocess.spawnfile. PR-URL: nodejs#31342 Fixes: nodejs#27206 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes:#27206
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes