win: change to use Python in install tool#31221
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
win: change to use Python in install tool#31221gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
devnexen
approved these changes
Jan 6, 2020
sam-github
approved these changes
Jan 6, 2020
63 tasks
richardlau
requested changes
Jan 6, 2020
Member
richardlau
left a comment
There was a problem hiding this comment.
The text being changed is in a dialog that, if checked, runs tools/msvs/install_tools/install_tools.bat. This currently installs/updates Python 2 and has corresponding text:
They should also be changed for consistency.
cclauss
approved these changes
Jan 6, 2020
008fbe8 to
bfa5a7a
Compare
richardlau
approved these changes
Jan 7, 2020
lpinca
approved these changes
Jan 7, 2020
BridgeAR
approved these changes
Jan 7, 2020
Trott
approved these changes
Jan 8, 2020
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM, but I have no way to test this and I don't think it's CI-testable? If a few people can confirm that they tested these changes and it worked for them, that would be good.
Collaborator
Member
|
Landed in 85ef944 |
Trott
pushed a commit
that referenced
this pull request
Jan 8, 2020
PR-URL: #31221 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 85ef944 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31221 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31221 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now our toolchain in Python3 compatible, this need to update.
cc @nodejs/platform-windows
Related: nodejs/node-gyp#1977 (comment).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes