Don't use -latomic on macOS#30099
Closed
ryandesign wants to merge 1 commit intonodejs:masterfrom
ryandesign:patch-1
Closed
Don't use -latomic on macOS#30099ryandesign wants to merge 1 commit intonodejs:masterfrom ryandesign:patch-1
ryandesign wants to merge 1 commit intonodejs:masterfrom
ryandesign:patch-1
Conversation
Fixes build when using open-source clang. (Builds using Apple clang from Xcode 7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.) Closes #30093
richardlau
approved these changes
Oct 23, 2019
Member
richardlau
left a comment
There was a problem hiding this comment.
Looks okay to me but I don't have a mac so can't test this.
cc @nodejs/platform-macos @nodejs/build-files
Collaborator
4 tasks
Member
|
Ping @nodejs/platform-macos @nodejs/build-files |
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
I don't have a mac anymore, so I can't test or verify this. |
Member
|
|
BridgeAR
pushed a commit
that referenced
this pull request
Jan 2, 2020
Fixes build when using open-source clang. Builds using Apple clang from Xcode v7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added. PR-URL: #30099 Fixes: #30093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 4bd0d8c 🎉 |
Member
|
@ryandesign congratulations on your first commit to Node.js! 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Fixes build when using open-source clang. Builds using Apple clang from Xcode v7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added. PR-URL: #30099 Fixes: #30093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Fixes build when using open-source clang. Builds using Apple clang from Xcode v7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added. PR-URL: #30099 Fixes: #30093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Fixes build when using open-source clang. Builds using Apple clang from Xcode v7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added. PR-URL: #30099 Fixes: #30093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
liu-kan
added a commit
to liu-kan/pynng
that referenced
this pull request
Aug 21, 2022
liu-kan
added a commit
to liu-kan/pynng
that referenced
this pull request
Aug 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build when using open-source clang. (Builds using Apple clang from Xcode
7 and later were already working, due to the fact that node's build system
misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.)
Closes #30093
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes