Closed
Conversation
richardlau
approved these changes
Oct 14, 2019
devnexen
approved these changes
Oct 14, 2019
Fishrock123
approved these changes
Oct 14, 2019
lpinca
approved these changes
Oct 14, 2019
Member
|
You can always count on me to mess this up. |
Trott
approved these changes
Oct 14, 2019
Member
|
Collaborators, +1 here to fast-track. I'd like to make sure a release candidate doesn't go out without this, for example. |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
Getting a clean CI on this will probably require landing #29979 first. |
2 tasks
Collaborator
Collaborator
jasnell
approved these changes
Oct 15, 2019
antsmartian
approved these changes
Oct 15, 2019
Collaborator
Member
|
Landed in ff5a1cf |
Trott
pushed a commit
that referenced
this pull request
Oct 16, 2019
Refs: #29061 PR-URL: #29969 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 22, 2019
Refs: #29061 PR-URL: #29969 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #29061
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes