src: allow fatal exceptions to be enhanced #28562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Jul 5, 2019
Member
Alternatively we can just use a normal |
Member
|
i'd say instead of having a concept of enhance we should just check for CanContinue, and always get a better trace if possible. |
5aa189d to
1f21d4f
Compare
Contributor
Author
|
Added a test, and took |
joyeecheung
approved these changes
Jul 5, 2019
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/24318/ EDIT(cjihrig): CI was green. |
Trott
approved these changes
Jul 6, 2019
addaleax
approved these changes
Jul 6, 2019
This commit allows fatal exceptions to be enhanced so that exceptions thrown from an unhandledException handler have the stack attached properly. PR-URL: nodejs#28562 Fixes: nodejs#28550 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
basti1302
added a commit
to instana/nodejs
that referenced
this pull request
Jul 7, 2019
The issue should be fixed in the next Node release, see nodejs/node#28562. Also, log a warning when Node.js v12.6.0 is used and uncaught exception reporting is enabled.
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit allows fatal exceptions to be enhanced so that exceptions thrown from an unhandledException handler have the stack attached properly. PR-URL: #28562 Fixes: #28550 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows fatal exceptions to be enhanced so that exceptions thrown from an
'unhandledException'handler have the stack attached properly.I still need to add a test, but first I want to make sure the approach is acceptable. If it's not, another approach could be passing
kEnhance/kDontEnhanceto theTryCatchScopeconstructor.Fixes: #28550
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes