test: refactor test-tls-enable-trace-cli.js #27553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
Contributor
|
Its possible that pumping some data through the connections before the |
sam-github
approved these changes
May 3, 2019
lpinca
approved these changes
May 3, 2019
Trott
approved these changes
May 3, 2019
Contributor
Author
|
The following error is happening in the child process: |
Contributor
|
Most of the ways that can happen look like BIO_write() not writing everything it was asked to, and it might have registered an error when it failed. Printing the err.opensslErrorStack might give some more info here. |
Collaborator
Collaborator
Contributor
|
Landed in 9a174db. |
danbev
pushed a commit
that referenced
this pull request
May 8, 2019
PR-URL: #27553 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 9, 2019
PR-URL: #27553 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test appears to be flakey on Unix. I'm not entirely sure why, but I think it may be related to the additional piping of the child process stderr (although this test is mostly a copy of another test that isn't exhibiting problems). This commit simplifies the test a bit.
Some preliminary testing seems promising:
If the stress test comes back green, I'd recommend fast tracking this.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes