test: allow EAI_FAIL in test-http-dns-error.js #27500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
richardlau
approved these changes
Apr 30, 2019
Member
richardlau
left a comment
There was a problem hiding this comment.
Maybe consider printing the actual err.code in the cases where the assertions fail.
Trott
approved these changes
Apr 30, 2019
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22857/ EDIT(cjihrig): CI was yellow. |
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: nodejs#27500 Fixes: nodejs#27487 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
2 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAI_FAILis expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makesEAI_FAILan acceptable error code on all platforms.Fixes: #27487
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes