stream: make async iteration stable by mcollina · Pull Request #26989 · nodejs/node

mcollina · 2019-03-29T16:17:03Z

I think it's about time we make Readable async iteration stable.
It has been around for a while - we have fixed a bunch of bugs so far, and I expect there will still be some. I do not expect major changes.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-03-29T16:17:05Z

@mcollina Sadly, an error occurred when I tried to trigger a build. :(

doc/api/stream.md

vsemozhetbyt · 2019-03-29T16:21:37Z

Is it worth to do the same for rl[Symbol.asyncIterator]()?

targos · 2019-03-29T16:24:05Z

why semver-major?

mcollina · 2019-03-29T16:31:25Z

why semver-major?

I don't know really.

mcollina · 2019-03-29T16:40:01Z

Is it worth to do the same for rlSymbol.asyncIterator?

I'm happy to include that in this PR.

jasnell · 2019-03-29T21:37:17Z

doc/api/stream.md

Suggested change

description: AsyncIterator support is not experimental anymore.

description: AsyncIterator support is no longer experimental.

benjamingr

🎉

mcollina · 2019-04-01T08:09:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22093/

nodejs-github-bot · 2019-04-01T08:09:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22093/

mcollina · 2019-04-01T08:11:03Z

I've also marked readline AsyncIterator support stable.

PTAL @vsemozhetbyt @jasnell @addaleax @benjamingr @cjihrig @BridgeAR @shisama

benjamingr

Still LGTM

PR-URL: #26989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163

Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163

mcollina · 2019-05-19T12:01:51Z

@nodejs/lts would you mind including this in the next v10 minor?

vschoener · 2019-05-21T10:17:20Z

That would be awesome :)

mcollina · 2019-09-04T11:20:11Z

@BethGriggs would you mind adding this to the next 10 release?

PR-URL: #26989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Notable changes: - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: - **deps**: update npm to 6.11.3 (claudiahdz) [#29430](#29430) - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: * crypto: * add support for chacha20-poly1305 for AEAD (chux0519) #24081 * increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799 * deps: * update npm to 6.11.3 (claudiahdz) #29430 * upgrade openssl sources to 1.1.1d (Sam Roberts) #29921 * dns: * remove dns.promises experimental warning (cjihrig) #26592 * fs: * remove experimental warning for fs.promises (Anna Henningsen) #26581 * http: * makes response.writeHead return the response (Mark S. Everitt) #25974 * http2: * makes response.writeHead return the response (Mark S. Everitt) #25974 * n-api: * make func argument of napi\_create\_threadsafe\_function optional (legendecas) #27791 * mark version 5 N-APIs as stable (Gabriel Schulhof) #29401 * implement date object (Jarrod Connolly) #25917 * process: * add --unhandled-rejections flag (Ruben Bridgewater) #26599 * stream: * implement Readable.from async iterator utility (Guy Bedford) #27660 * make Symbol.asyncIterator support stable (Matteo Collina) #26989 PR-URL: #29875

mcollina added stream Issues and PRs related to the stream subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 29, 2019

mcollina requested review from a team and jasnell March 29, 2019 16:17

mcollina mentioned this pull request Mar 29, 2019

ReadableStream[Symbol.asyncIterator] path to stability nodejs/readable-stream#333

Closed

cjihrig approved these changes Mar 29, 2019

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

vsemozhetbyt added the promises Issues and PRs related to ECMAScript promises. label Mar 29, 2019

mcollina added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 29, 2019

BridgeAR approved these changes Mar 29, 2019

View reviewed changes

jasnell reviewed Mar 29, 2019

View reviewed changes

jasnell approved these changes Mar 29, 2019

View reviewed changes

shisama approved these changes Mar 30, 2019

View reviewed changes

addaleax approved these changes Mar 30, 2019

View reviewed changes

BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 31, 2019

benjamingr approved these changes Mar 31, 2019

View reviewed changes

mcollina added 2 commits April 1, 2019 10:08

stream: make async iteration stable

9636a35

readline: make AsyncIterator stable

8df8328

mcollina force-pushed the make-readable-async-iterator-stable branch from 9b5ab18 to 8df8328 Compare April 1, 2019 08:09

benjamingr approved these changes Apr 1, 2019

View reviewed changes

addaleax approved these changes Apr 1, 2019

View reviewed changes

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

cjihrig mentioned this pull request May 2, 2019

Advance Readable[Symbol.asyncIterator] out of experimental #26479

Closed

mcollina added the lts-watch-v10.x label May 19, 2019

BethGriggs added the backport-requested-v10.x label Oct 16, 2019

BethGriggs added land-on-v10.x and removed backport-requested-v10.x labels Oct 18, 2019

BethGriggs mentioned this pull request Oct 18, 2019

v10.17.0 proposal #29875

Merged

jepstein-eagle mentioned this pull request Jun 11, 2020

Fix ExperimentalWarning: Readable[Symbol.asyncIterator] error stylelint/stylelint#4794

Closed

	description: AsyncIterator support is not experimental anymore.
	description: AsyncIterator support is no longer experimental.

Uh oh!

Conversation

mcollina commented Mar 29, 2019

Checklist

Uh oh!

nodejs-github-bot commented Mar 29, 2019

Uh oh!

Uh oh!

vsemozhetbyt commented Mar 29, 2019

Uh oh!

targos commented Mar 29, 2019

Uh oh!

mcollina commented Mar 29, 2019

Uh oh!

mcollina commented Mar 29, 2019

Uh oh!

jasnell Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Apr 1, 2019

Uh oh!

nodejs-github-bot commented Apr 1, 2019

Uh oh!

mcollina commented Apr 1, 2019

Uh oh!

benjamingr left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented May 19, 2019

Uh oh!

vschoener commented May 21, 2019

Uh oh!

mcollina commented Sep 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants