Closed
Conversation
This strictens to rule to validate comments from 30 characters on.
Member
|
Can we also maybe punctuate the comments in the same go? We don’t lint this for C++, but it’s been a common review comment. |
Member
Author
|
@addaleax I would like to do that but not manually and currently I can only think about writing a new eslint rule to automate it properly. If anyone has a suggestion to automate it in a simple fashion, I am happy to do that. |
vsemozhetbyt
approved these changes
Mar 7, 2019
Contributor
vsemozhetbyt
left a comment
There was a problem hiding this comment.
With some false-positive and consistency nits.
Member
Author
|
@vsemozhetbyt I addressed your comments and also added a couple of dots while going through your comments. |
targos
approved these changes
Mar 9, 2019
Member
Author
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 9, 2019
PR-URL: nodejs#26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 9, 2019
This strictens to rule to validate comments from 30 characters on. PR-URL: nodejs#26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
Author
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
This strictens to rule to validate comments from 30 characters on. PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
This strictens to rule to validate comments from 30 characters on. PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
This strictens to rule to validate comments from 30 characters on. PR-URL: #26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stricten the lint rule to validate all comments from 30 characters on.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes