tools: make mkssldef ignore DEPRECATEDIN#24329
Closed
refack wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Contributor
Author
|
/CC @nodejs/python @nodejs/build-files @nodejs/crypto |
bnoordhuis
approved these changes
Nov 13, 2018
| if meta[0] != 'EXIST': continue | ||
| if meta[2] != 'FUNCTION': continue | ||
| # In cases where meta[3] is 'DEPRECATEDIN_X_Y,CATEGORY' | ||
| meta[3] = meta[3].split(',')[-1] |
Member
There was a problem hiding this comment.
Can you check that the zeroth field is what you expect it to be?
if ',' in meta[3]:
fst, meta[3] = meta[3].split(',')
assert fst.startswith('DEPRECATEDIN')The above assumes at most two fields. You could also filter out all deprecation tags:
words = meta[3].split(',')
words = [word for word in words if not word.startswith('DEPRECATEDIN')]
assert len(words) == 1
meta[3] = words.pop()
Member
|
Maybe add the testcase from #20369? |
Member
|
Since this didn't land, I've opened an alternative PR which adds the deprecated categories to the list of categories to export (rather than trying to ignore them): #25991. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
mkssldefignore deprecation. e.g.TLSv1_2_*that were deprecated in openSSL_1_1:node/deps/openssl/openssl/util/libssl.num
Line 157 in 49b0f7f
Fixes: #20369
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes