Closed
Conversation
Update ESLint to 5.8.0.
Member
|
Rubber stamp lgtm |
Member
|
Look at that beautiful tiny diff! Only 33 files! |
Member
|
Seems fast-trackable but I know @cjihrig is not big on using fast-track when not necessary, so I'll hold back unless he requests it.... |
4 tasks
danbev
approved these changes
Oct 29, 2018
Contributor
|
Landed in 2f1c356. |
danbev
pushed a commit
that referenced
this pull request
Oct 29, 2018
Update ESLint to 5.8.0. PR-URL: #23904 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
Update ESLint to 5.8.0. PR-URL: #23904 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Nov 2, 2018
Contributor
|
Would someone be able to backport the upgraded linter to 8.x |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
Update ESLint to 5.8.0. PR-URL: #23904 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Update ESLint to 5.8.0. PR-URL: #23904 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Update ESLint to 5.8.0. PR-URL: #23904 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 5.8.0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes