src: remove long-deprecated APIs without Isolate* arg#23178
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove long-deprecated APIs without Isolate* arg#23178addaleax wants to merge 1 commit intonodejs:masterfrom
Isolate* arg#23178addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
2 tasks
cjihrig
approved these changes
Sep 30, 2018
joyeecheung
approved these changes
Sep 30, 2018
refack
approved these changes
Sep 30, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Sep 30, 2018
jasnell
approved these changes
Oct 1, 2018
These have been deprecated since 75adde0 (February 2014) and most likely do not see much ecosystem usage to begin with.
f44590c to
9b96464
Compare
Member
Author
Member
Author
Member
Author
|
Landed in 3d21245 |
addaleax
added a commit
that referenced
this pull request
Oct 4, 2018
These have been deprecated since 75adde0 (February 2014) and most likely do not see much ecosystem usage to begin with. PR-URL: #23178 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
These have been deprecated since 75adde0 (February 2014) and most likely do not see much ecosystem usage to begin with. PR-URL: #23178 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have been deprecated since 75adde0
(February 2014) and most likely do not see much ecosystem usage
to begin with.
(Currently blocked on the linter fix in #23177)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes