tty: handle setRawMode errors#22886
Closed
seishun wants to merge 1 commit intonodejs:masterfrom
seishun:setRawMode-error
Closed
tty: handle setRawMode errors#22886seishun wants to merge 1 commit intonodejs:masterfrom seishun:setRawMode-error
seishun wants to merge 1 commit intonodejs:masterfrom
seishun:setRawMode-error
Conversation
Member
|
Is it possible (and not too onerous) to add a reliable test that will cover the error condition? |
Contributor
Author
|
I don't think it's possible to trigger an error intentionally. |
addaleax
approved these changes
Sep 17, 2018
Contributor
Author
Fishrock123
approved these changes
Sep 17, 2018
Contributor
Fishrock123
left a comment
There was a problem hiding this comment.
Is that major? I'm not really sure. I guess in theory errors should be so uncommon that it doesn't matter?
Contributor
Author
cjihrig
approved these changes
Sep 18, 2018
Contributor
|
Re-run of CI: https://ci.nodejs.org/job/node-test-commit-linux/21689/ was successful. |
Contributor
|
Landed in a82fc30. |
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #21773
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes