replaced almost all var with let and const#19454
Closed
vitpavlenko wants to merge 1 commit intonodejs:masterfrom
Closed
replaced almost all var with let and const#19454vitpavlenko wants to merge 1 commit intonodejs:masterfrom
vitpavlenko wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
thanks for the pr! however, we don't merge changes like this. as parts of the project are refactored they get upgraded. this pr would mess up our git blame and history |
Member
|
Ref #13756 |
Member
|
As mentioned by other people, we would like to not do changes like this en masse. Thank you for your contribution though, and I encourage you to take a look at our other issues :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesreplaced var with let or const but saved var in for