doc: add missing URL types in fs promise API#18599
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-fs-promise-url
Closed
doc: add missing URL types in fs promise API#18599vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-fs-promise-url
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-fs-promise-url
Conversation
Contributor
Author
cjihrig
approved these changes
Feb 6, 2018
styfle
approved these changes
Feb 6, 2018
Member
|
doh! thank you! I had seen but completely forgot about that comment in the original PR. |
jasnell
approved these changes
Feb 6, 2018
iwko
approved these changes
Feb 6, 2018
Contributor
Author
|
Landed in ac829f0 |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This seems to be slipped in nodejs#18297 PR-URL: nodejs#18599 Refs: nodejs#18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, fs
This seems to be slipped in #18297
Refs: #18309
cc @jasnell