http2: add a number of checks for server close callback#18182
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
http2: add a number of checks for server close callback#18182jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
Verify that server close callbacks are being called
Member
Author
addaleax
approved these changes
Jan 17, 2018
BridgeAR
approved these changes
Jan 19, 2018
Member
|
Landed in 0a1adc0 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 19, 2018
Verify that server close callbacks are being called PR-URL: nodejs#18182 Refs: nodejs#18176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
Should this be backported to |
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Verify that server close callbacks are being called PR-URL: nodejs#18182 Refs: nodejs#18176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Verify that server close callbacks are being called PR-URL: nodejs#18182 Refs: nodejs#18176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that server close callbacks are being called
Refs: #18176
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2